Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regex or Partial field Name/ID matches of login entries #67

Open
skibbipl opened this issue Nov 11, 2017 · 5 comments
Open

Regex or Partial field Name/ID matches of login entries #67

skibbipl opened this issue Nov 11, 2017 · 5 comments

Comments

@skibbipl
Copy link

Hello,
My second bank uses randomized field id to prevent autofill. Is it possible to mach field ids in kee based on some regexp?
Example HTML:

<input name="client_id_field_5638661431-client" value="" id="f-form_5638661431-client_id_field" maxlength="50" size="62" class="text_input text_input_client_id_field NullValidationCharEditField" tabindex="10" aria-flowto="f-form_5638661431-client_id_field-help" type="text">

and after page refresh:

<input name="client_id_field_4991412534-client" value="" id="f-form_4991412534-client_id_field" maxlength="50" size="62" class="text_input text_input_client_id_field NullValidationCharEditField" tabindex="10" aria-flowto="f-form_4991412534-client_id_field-help" type="text">
@luckyrat
Copy link
Member

Field IDs are only one part of what Kee uses to decide what to fill in where. So it is possible that your bank has structured their forms in a way that means the random IDs cause a problem but equally, it could be worth you trying with the latest beta version which has a few bug fixes and improvements that might make this issue moot.

We might be able to add support for regex pattern matching if necessary but it would be expensive - possibly too slow to be acceptable. I'd want to get some performance benchmarks before and after... which we don't have any way to produce at the moment. So that feature definitely wouldn't make it on to the short-term roadmap.

@skibbipl
Copy link
Author

Regex matching could be disabled by default, and enabled only for specific sites. If you need some some performance benchmarks I can definitely execute them on my bank site.

@luckyrat luckyrat changed the title Randomized field ids Regex or Partial field Name/ID matches of login entries Apr 10, 2018
@luckyrat
Copy link
Member

I still don't think it's very likely that we'll implement support for regex in this way but if the improvements I'm planning over the next year or two still don't cover all situations like the randomly generated ID example above, we'll be in a much better place to then add some regex support, with appropriate performance tests and warnings of course.

@KuroSetsuna29
Copy link

I can see how regex can be expensive performance, but possibly just adding ability for CSS Selectors would be enough.
In the above example the following CSS selector could work: input[name*="client_id_field"], and in my situations the fields I want to include/exclude do not have an ID or name attribute.

@luckyrat
Copy link
Member

Yeah, CSS selectors are definitely higher up the priority list than regexs but even with those, we'll need some thorough performance testing since they aren't free to evaluate and could cause their own problems if users configure selectors that match many elements on a page. Maybe we'd need a maximum limit and error log message to encourage users to fix their selectors in that case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants