fix: Use median-time-past for input sequence checks rather than block… #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@m-kus. Kindly review so i can proceed with the scripts. |
m-kus
reviewed
Oct 6, 2024
m-kus
reviewed
Oct 7, 2024
m-kus
reviewed
Oct 7, 2024
m-kus
reviewed
Oct 7, 2024
scripts/data/generate_data.py
Outdated
| @@ -173,37 +185,41 @@ def fetch_block(block_hash: str, fast: bool): | |||
| ) | |||
|
|
|||
| block["data"] = { | |||
| tx["txid"]: resolve_transaction(tx, previous_outputs) | |||
| tx["txid"]: resolve_transaction( | |||
| tx, previous_outputs, block["mediantime"] | |||
There was a problem hiding this comment.
Ok, so you need to do some more changes, because here you should provide current_chain_state["median_time_past"]
You need to implement an "apply" function for chain state that would produce next_chain_state from the current_chain_state. Then you provide chain_state to the fetch_block function to get MTP.
As a bonus you'll be able to get rid of fetch_chain_state function because now you are computing it from the previous ones.
maciejka
reviewed
Oct 7, 2024
scripts/data/generate_data.py
Outdated
| @@ -71,6 +77,7 @@ def fetch_chain_state_fast(block_height: int): | |||
| head["epoch_start_time"] = 1231006505 | |||
| else: | |||
| head["epoch_start_time"] = int(data["epoch_start_time"]) | |||
| head["median_time_past"] = compute_median_time_past(head["prev_timestamps"]) | |||
There was a problem hiding this comment.
median_time is already in the data (check if it is correct)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… time