Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: support dual interfaces for all external facing contracts #240

Open
sparqet opened this issue Sep 5, 2023 · 4 comments
Open

Feat: support dual interfaces for all external facing contracts #240

sparqet opened this issue Sep 5, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@sparqet
Copy link
Collaborator

sparqet commented Sep 5, 2023

Description

External facing smart contracts should implement dual facing interfaces to allow better composability. It means that this contracts should support snake_case and CamelCase at the same time for external functions.

Example on open-zeppelin: OpenZeppelin/cairo-contracts#596

@sparqet sparqet added the enhancement New feature or request label Sep 5, 2023
@Sk8erboi84 Sk8erboi84 changed the title feat: support dual interfaces for all external facing contracts Feat: support dual interfaces for all external facing contracts Sep 5, 2023
@dbejarano820
Copy link
Contributor

I assume this one will be for later right

@delaaxe
Copy link
Contributor

delaaxe commented Sep 5, 2023

why is this needed for a brand new protocol on Cairo 2 though?

@zarboq
Copy link
Collaborator

zarboq commented Sep 5, 2023

It's to facilitate integration of products that already exists for GMX on EVM such as https://twitter.com/Puppetcopy.

But I don't think it's high priority yet. Let's build a working app first 🚀

@tarrencev
Copy link

Imo it would be better to handle this on the sdk side. Applications like Puppetcopy would already need a starknet sdk. It can easily abstract this by converting camel case to snake case before constructing the txn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants