Feat: Implement the function in the market_utils library #3

[Tbelleng]

Pull Request type

Please add the labels corresponding to the type of changes your PR introduces:

• Bugfix
• Feature

What is the current behavior?

Currently, functions are working but since last git pull i wasnt able to trigger tests
Resolves: #NA

What is the new behavior?

• Implement from getMaxPositionImpactFactor function to getExpectedMinTokenBalance in the market_utils library.
• Had to change some external files because functions prototypes or return values was not working
• Add functions to convert int and uint.
• Some function are still missing from other files (the last function of market_utils Feat: Implement the function in the market_utils library. #3 #435 use some Keys functions that exist in solidity files but not in satoru files (i commented the line with what it should looks like)
• Commented "test_deposit_utils::given_unsufficient_fee_token_amount_for_deposit_then_fails" because one function essential function (get_market) was missing in Satoru. (Approved by @zarboq)

Does this introduce a breaking change?

No

Other information

[Tbelleng]

• Tests passed
• Commented "test_deposit_utils::given_unsufficient_fee_token_amount_for_deposit_then_fails" because one function essential function (get_market) was missing in Satoru. (Approved by @zarboq)

[Tbelleng]

I did the error function for MAX_SWAP_PATH_LENGTH_EXCEEDED, but for an unknown reason it failed the test "tests::exchange::test_withdrawal_handler::given_normal_conditions_when_create_withdrawal_then_works".

its return the following failed test "[FAIL] tests::exchange::test_withdrawal_handler::given_normal_conditions_when_create_withdrawal_then_works

Failure data:
original value: [2948898997531897529390896139788207291365863622618688546988264006116708], converted to a string: [max_swap_path_length_exceeded]
original value: [0], converted to a string: []
original value: [0], converted to a string: []"

Any hint about it ?

[zarboq]

It's bc you inverted the inequality, it should be if token_swap_path_length.into() > max_swap_path_length @Tbelleng

[Tbelleng]

My bad ! thanks @zarboq , it should works now ⚡️

[Tbelleng]

solved issues but after removing "get_open_interest" as requested, i got this error when compiling "error: WithdrawalHandler: failed to compile Sierra contract to CASM

Caused by:
#35998: One of the arguments does not satisfy the requirements of the libfunc." did i do something wrong ?

[zarboq]

Do this in get_borrowing_factor_per_second

let market_snap = @market;
if (skip_borrowing_fee_for_smaller_side) {
    let long_open_interest: u128 = get_open_interest_for_market_is_long(data_store, market_snap, true);
    let short_open_interest: u128 = get_open_interest_for_market_is_long(data_store, market_snap, false);

    // if getting the borrowing factor for longs and if the longOpenInterest
    // is smaller than the shortOpenInterest, then return zero
    if (is_long && long_open_interest < short_open_interest) {
        return 0;
    }
    // if getting the borrowing factor for shorts and if the shortOpenInterest
    // is smaller than the longOpenInterest, then return zero
    if (!is_long && short_open_interest < long_open_interest) {
        return 0;
    }
}

Not sure why but looks like market gets "trapped" in the if