feat : added different proxy versions in proxy client #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ocdbytes
commented
Jul 2, 2024
ocdbytes
commented
- Added different proxy versions :
- OpenZeppelin proxy
- Starknet Proxy 3.0.2
- Starknet Proxy 5.0.0
- Unsafe Proxy (for fast testing or dev environment)
- Added proxy client functions :
- deploy_contract_behind_safe_proxy_3_0_2
- deploy_contract_behind_safe_proxy_5_0_0
added 11 commits
July 2, 2024 12:13
apoorvsadana
reviewed
Jul 3, 2024
There was a problem hiding this comment.
let's move this code into an interfaces folder with different files depending on version number
| function proxyAcceptGovernance() external | ||
| ]"#, | ||
| ); | ||
|
|
||
| #[async_trait] | ||
| pub trait ProxySupportTrait<M: Middleware> { |
There was a problem hiding this comment.
let's rename this with the version number as well
|
|
||
| pub struct StarkgateManagerContractClient { | ||
| manager: StarkgateManager<LocalWalletSignerMiddleware>, | ||
| proxy_support: ProxySupport<LocalWalletSignerMiddleware>, | ||
| proxy_support: ProxySupportLatest<LocalWalletSignerMiddleware>, |
There was a problem hiding this comment.
let's rename this as well according to versions
| @@ -62,8 +57,14 @@ pub async fn deploy_contract_behind_safe_proxy<T: Tokenize>( | |||
|
|
|||
| log::debug!("ℹ️ Contract deployed : {:?}", contract.address().clone()); | |||
|
|
|||
| let type_of_proxy = match proxy_type { | |||
There was a problem hiding this comment.
Suggested change
| let type_of_proxy = match proxy_type { | |
| let proxy_code = match proxy_type { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.