Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CONTRACTS] implement _get_available_liquidity tests #90

Closed
0xChqrles opened this issue Sep 23, 2024 · 13 comments · Fixed by #108
Closed

[CONTRACTS] implement _get_available_liquidity tests #90

0xChqrles opened this issue Sep 23, 2024 · 13 comments · Fixed by #108
Assignees
Milestone

Comments

@0xChqrles
Copy link
Contributor

The tests are already defined in src/contracts/ramps/revolut/revolut_test.cairo. You just need to write their implementation following the way the escrow tests are implemented.

These contracts will be holding funds, so it's of utmost importance that the tests cover 100% of possible use cases, are readable, easily modifiable, and consistent.

To better understand how the contracts work, please read this article How to manage liquidity in a P2P ramping app

These tests are also related to #89

@mubarak23
Copy link
Contributor

mubarak23 commented Sep 23, 2024

@0xChqrles am available to work on this.

I am a Cairo smart contract developer with experience working on projects such as Just Art Peace, Dojo, Kart, TBA, and Shinigami. Before transitioning to Cairo development, I was a backend developer specializing in Rust.

i also work and understand the codebase base on my previous experience working on issue #33 and #50 on this project

My recent work with cairo starknet

@Jemiiah
Copy link
Contributor

Jemiiah commented Sep 23, 2024

i would love to work on this @0xChqrles

Copy link

onlydustapp bot commented Sep 23, 2024

Hey @mubarak23!
Thanks for showing interest.
We've created an application for you to contribute to Zkramp.
Go check it out on OnlyDust!

Copy link

onlydustapp bot commented Sep 23, 2024

Hey @Jemiiah!
Thanks for showing interest.
We've created an application for you to contribute to Zkramp.
Go check it out on OnlyDust!

@Calebux
Copy link

Calebux commented Sep 23, 2024

@0xChqrles I'll to work on this issue

Copy link

onlydustapp bot commented Sep 23, 2024

Hey @Calebux!
Thanks for showing interest.
We've created an application for you to contribute to Zkramp.
Go check it out on OnlyDust!

@od-hunter
Copy link

Hi @0xChqrles , can I work on this please?

Copy link

onlydustapp bot commented Sep 23, 2024

Hey @od-hunter!
Thanks for showing interest.
We've created an application for you to contribute to Zkramp.
Go check it out on OnlyDust!

@Benjtalkshow
Copy link

Hello @0xChqrles ,
Can I be assigned to this? I can tackle this issue asap.

Copy link

onlydustapp bot commented Sep 24, 2024

Hey @Benjtalkshow!
Thanks for showing interest.
We've created an application for you to contribute to Zkramp.
Go check it out on OnlyDust!

@Gift-Naomi
Copy link

@0xChqrles can I work on this?

@Akshola00
Copy link

@0xChqrles Hi, Im available to work on this

@leohscl
Copy link
Contributor

leohscl commented Oct 3, 2024

I'm up for this one @0xChqrles

leohscl added a commit to leohscl/zkramp that referenced this issue Oct 8, 2024
new tests are very similar to available_liquidity tests

 [CONTRACTS] implement _get_available_liquidity tests keep-starknet-strange#90
0xChqrles pushed a commit that referenced this issue Oct 8, 2024
new tests are very similar to available_liquidity tests

 [CONTRACTS] implement _get_available_liquidity tests #90
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants