Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CONTRACTS] implement register and is_registered tests #93

Closed
0xChqrles opened this issue Sep 23, 2024 · 14 comments · Fixed by #98
Closed

[CONTRACTS] implement register and is_registered tests #93

0xChqrles opened this issue Sep 23, 2024 · 14 comments · Fixed by #98
Assignees
Milestone

Comments

@0xChqrles
Copy link
Contributor

The tests are already defined in src/components/registry/registry_test.cairo. You just need to write their implementation following the way the escrow tests are implemented.

These contracts will be holding funds, so it's of utmost importance that the tests cover 100% of possible use cases, are readable, easily modifiable, and consistent.

To better understand how the contracts work, please read this article How to manage liquidity in a P2P ramping app

@ikemHood
Copy link
Contributor

ikemHood commented Sep 23, 2024

Hello @0xChqrles , can i work on this?

Copy link

onlydustapp bot commented Sep 23, 2024

Hey @ikemHood!
Thanks for showing interest.
We've created an application for you to contribute to Zkramp.
Go check it out on OnlyDust!

@ShantelPeters
Copy link

Kindly assign @0xChqrles

@manlikeHB
Copy link
Contributor

Hi @0xChqrles, can i work on this?

Copy link

onlydustapp bot commented Sep 23, 2024

Hey @manlikeHB!
Thanks for showing interest.
We've created an application for you to contribute to Zkramp.
Go check it out on OnlyDust!

@TropicalDog17
Copy link

Hi @0xChqrles can I work on this issue, I have experience in Cairo and Rust, and I am confident to complete the task.

keep-starknet-strange/raito#196
near/near-sdk-rs#1220

Copy link

onlydustapp bot commented Sep 23, 2024

Hey @TropicalDog17!
Thanks for showing interest.
We've created an application for you to contribute to Zkramp.
Go check it out on OnlyDust!

@PavitraAgarwal21
Copy link

Hey can I work on this

Copy link

onlydustapp bot commented Sep 23, 2024

Hey @PavitraAgarwal21!
Thanks for showing interest.
We've created an application for you to contribute to Zkramp.
Go check it out on OnlyDust!

@raizo07
Copy link

raizo07 commented Sep 23, 2024

@0xChqrles Hello, can I be assigned to work on this?

Copy link

onlydustapp bot commented Sep 23, 2024

Hey @raizo07!
Thanks for showing interest.
We've created an application for you to contribute to Zkramp.
Go check it out on OnlyDust!

@Benjtalkshow
Copy link

Hello @0xChqrles ,
Can I be assigned to this? I can tackle this issue asap.

Copy link

onlydustapp bot commented Sep 24, 2024

Hey @Benjtalkshow!
Thanks for showing interest.
We've created an application for you to contribute to Zkramp.
Go check it out on OnlyDust!

@thesledge04
Copy link

hello @0xChqrles can i be assigned this task?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants