Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

violation_point.color #40

Open
blagburn opened this issue Dec 14, 2018 · 3 comments
Open

violation_point.color #40

blagburn opened this issue Dec 14, 2018 · 3 comments

Comments

@blagburn
Copy link

Hello,
Thank you in advance for your help! I am utilizing your package and I am having an issue with the point color for qc violations. I was hoping you would have an idea of what I am doing wrong.

m_base_count <- ggplot(diehard, aes(x = Date Opened, y = n)) + stat_qc_violations(method = "XmR", violation_point.color = "Red") + ggtitle("All Violations") m_base_count

screenshot_2018-12-13 qa dashboard

Please let me know if the picture does not work. I am very to Github.

@kenithgrey
Copy link
Owner

kenithgrey commented Dec 14, 2018

Hi Blagburn, thanks for reaching out. I checked the following sample code on my end and got the offending points to turn blue.

stat_qc_violations(method = "XmR", violation_point.color = "blue")

Looking over your plots, I did see a single red dot in the 3 sigma violations plot. I also checked the rules in your other plots too see if there was anything else that was supposed to be marked.

Violation Same Side: 8 or more consecutive, same-side points - No violating points

Violation 1 Sigma: 4 or more consecutive, same-side points exceeding 1 sigma - No violating points

Violation 2 Sigma: 2 or more consecutive, same-side points exceeding 2 sigma - No violating points

Violation 3 Sigma: any points exceeding 3 sigma - One violating point

Please let me know if this was a different result than you were expecting.

Best regards,

KG

@kenithgrey
Copy link
Owner

Ok, after reviewing the violation rules in a reference book. ggQC needs a revision to its violation detection. The only facets that are completely correct are the same side facet and the 3 sigma facet. The 1 and 2 sigma facets need revision:

For example, the rule being used for 1 sigma violation is 4 or more consecutive, same-side points exceeding 1 sigma. The actual rule is... "whenever at least 4/5 successive points fall on the the same side of the center-line and the points exceed 1 sigma. ..

Thanks for reporting the error.

@blagburn
Copy link
Author

blagburn commented Dec 14, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants