Skip to content

Commit

Permalink
fix: adding file name validation before adding file to database (#104)
Browse files Browse the repository at this point in the history
  • Loading branch information
Caixetadev committed Jan 25, 2024
1 parent 7f638b0 commit 24f5dd6
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions src/handlers/image/handleImageUpload.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,14 +24,17 @@ func HandleImageUpload(c *gin.Context) {
c.String(http.StatusBadRequest, "Failed to open file: %s", err.Error())
return
}

defer file.Close()

fileBuffer := make([]byte, 512)

_, err = file.Read(fileBuffer)
if err != nil {
c.String(http.StatusInternalServerError, "Failed to read file: %s", err.Error())
return
}

fileType := http.DetectContentType(fileBuffer)

allowedMimeTypes := map[string]bool{
Expand All @@ -58,14 +61,13 @@ func HandleImageUpload(c *gin.Context) {
filename = newName + filepath.Ext(fileHeader.Filename)
}

savedFilename, alreadyExists := database.AddImage(filename, fileHashBuffer[:])

filteredFilename, err := util.FilterFilename(filename)
if err != nil {
c.String(http.StatusBadRequest, err.Error())
return
}

savedFilename, alreadyExists := database.AddImage(filename, fileHashBuffer[:])
if !alreadyExists {
err = c.SaveUploadedFile(fileHeader, util.ExPath+"/uploads/images/"+filteredFilename)
if err != nil {
Expand Down

0 comments on commit 24f5dd6

Please sign in to comment.