Support exclusion file filters #826
Conversation
srikary12
commented
Jun 19, 2024
srikary12
commented
- Closes [IDEA] Support exclusion file filters #728
- Adds file filter similar to word filters
There was a problem hiding this comment.
Hey @srikary12, just left 1 comment (to add tests) but otherwise changes look good! Excited to get file filters to word filter parity
|
@debanjum Can you check and let me know if it's working fine. |
This reverts commit f0bb8fa.
…to file-exclusion
file filter test cases
|
@debanjum @sabaimran let me know if there are any issues |
|
@debanjum added the case |
| def test_exclude_file_filter_terms(): | ||
| # Arrange | ||
| file_filter = FileFilter() | ||
| q_with_filter_terms = 'head tail file:-"file 1.org" file:"/path/to/dir/*.org"' |
There was a problem hiding this comment.
Shouldn't the tested query be something like below?
| q_with_filter_terms = 'head tail file:-"file 1.org" file:"/path/to/dir/*.org"' | |
| q_with_filter_terms = 'head tail -file:"file 1.org" file:"/path/to/dir/*.org"' |
| def test_file_exclude_filter(): | ||
| # Arrange | ||
| file_filter = FileFilter() | ||
| q_with_exclude_filter = 'head -"exclude_file" tail' |
There was a problem hiding this comment.
The query tested seems to be for word filters instead of file filters. Wouldn't the query with file filter be of the form:
| q_with_exclude_filter = 'head -"exclude_file" tail' | |
| q_with_exclude_filter = 'head -file:"/path/to/excluded_file" tail' |
| def test_file_include_and_exclude_filter(): | ||
| # Arrange | ||
| file_filter = FileFilter() | ||
| q_with_include_and_exclude_filter = 'head "include_file" -"exclude_file" tail' |
There was a problem hiding this comment.
The query tested seems to be for word filters instead of file filters. Wouldn't the query with file filter be of the form:
| q_with_include_and_exclude_filter = 'head "include_file" -"exclude_file" tail' | |
| q_with_include_and_exclude_filter = 'head file:"include_file" -file:"exclude_file" tail' |
| @@ -87,6 +87,42 @@ def test_get_file_filter_terms(): | |||
| assert filter_terms == ["file 1\\.org", "/path/to/dir/.*\\.org"] | |||
|
|
|||
|
|
|||
| def test_exclude_file_filter_terms(): | |||
There was a problem hiding this comment.
A more appropriate name for this unit test maybe test_include_and_exclude_file_filter_terms
| def test_exclude_file_filter_terms(): | |
| def test_include_and_exclude_file_filter_terms(): |
|
Sure, I'll be working on it. Thanks. |
