-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Device placement is logged by default #88
Comments
Since the experiments have been removed, there is only one remaining place this is used (the |
I can't get the code in that notebook to run. First of all, it depends on
Its somewhat unclear what the intention behind that notebook is in the first place. Maybe it should have been removed together with the experiments. What do you think @prithagupta @kiudee? This is the notebook in question: https://github.com/kiudee/cs-ranking/blob/master/docs/notebooks/Visualize-NeuralNetwork.ipynb |
@timokau I made this notebook so that, we can have one notebook to visualize the network. But I don't think it is needed now that we have the tensor board and users can do that if they want it themselves. I think you can remove it. |
We have a utility function
configure_numpy_keras
which is used in some of the experiment scripts:cs-ranking/csrank/tensorflow_util.py
Lines 40 to 58 in a635d59
It does the following:
KERAS_BACKEND
to TensorflowThere are a few issues (and maybe more) with this:
log_device_placement
is set toTrue
, which can cause slowdowns due to logging and should beFalse
by default.tensorflow_util.py
is the correct location, if the function is only ever used in experiments.The text was updated successfully, but these errors were encountered: