Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve error logs on T2CR disputes #75

Open
clesaege opened this issue Jan 17, 2020 · 5 comments
Open

Solve error logs on T2CR disputes #75

clesaege opened this issue Jan 17, 2020 · 5 comments
Assignees

Comments

@clesaege
Copy link
Member

clesaege commented Jan 17, 2020

One person did not manage to see case 154 and 153 (token dispute in the t2cr).
Edit: He was running his own node, so this may be where the problem was from, switching to infura solved the issue/

He got some error logs.
When I tried, I also got the same error logs but the dispute was displayed correctly.

Chrome:
bug

Firefox:
bug1

Brave:
bug2

@ghost
Copy link

ghost commented Jan 18, 2020

The two major errors I could find are indeed the following:

  1. Only works when using Infura. Impossible to use blockchain as it is designed by using a custom node. If you need to do testings and don't have a custom node, just add another public node in your Metamask RPC list, such as https://cloudflare-eth.com, and see if anything break. Nothing should break.

  2. The only way to make it work in Brave was clicking on the "Load Unsafe Scripts" button.
    2a. Brave is a major Web3 browser, it should be supported properly.
    2b. Load unsafe script being necessary to use the dapp does not show that good security practices are used throughout the project.

Thanks.

@ghost
Copy link

ghost commented Jan 22, 2020

I was able to find more details on this:

On my point 2, load "Unsafe Scripts" is not necessary if you are not using the "IPFS Companion" browser plugin.

Which means, that the website is breaking under the circumstances of an user using either their own Ethereum node and/or their own IPFS node. Both those things would be considered best practice from the user side.

I strongly recommend you use a testing environment, not connected in any way to the development environment, where you use:

  • Brave
  • A dedicated Ethereum node
  • A dedicated IPFS node

Ideally, the Kleros interface should work on IPFS, without any web server. Fixing those issues will get you closer to that goal.

@satello
Copy link
Contributor

satello commented Jan 31, 2020

  1. When I test with cloudflare gateway I am able to fetch basic data such as account balances but it seems unable to handle event logs. Many ethereum gateways do not support filter methods so I suspect that is what is happening here. I suspect light nodes also will not be able to handle event logs. Might need a connection to a full node in order to get full functionality. Are you using a light node?

  2. I could use some help reproducing this. Using Brave on MacOS I do not get a "Load Unsafe Scripts" message. I have tried it both with and without IPFS Companion. Does this only happen in combination with using your own ETH node?

As for the other error logs: Court policies on ipfs are being loaded with the full url (as opposed to /ipfs/...), so we are trying to re-verify them and this fails. It does not effect the site from loading, but we can fix this by updating the URI format in the Policy Registry. The legacy rate exceeded message comes from using injected web3 from metamask (infura with no api key). It does not seem to effect the site loading, but it would be nice to figure out a way to not rely on injected web3. The issue with this is it would nullify the use of your own node or alternate provider.

@ghost
Copy link

ghost commented Feb 2, 2020

https://court.kleros.io/ does not work when using a personal full node (or I suppose any node at all, aside from Infura). Is Infura hardcoded somewhere? To confirm, I am indeed using a full node. If there's anything I can help troubleshoot, I'm happy to do so.

I am currently not able to reproduce the "Load Unsafe Scripts" error, not sure if something got updated somewhere but I will report back if it happens again.

@LukeWheeldon
Copy link

I am having this issue as well when using a local node. When Metamask is configured to use Infura, it works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants