translation: refine translation of chapter_heap/summary.md #1383
Conversation
yuelinxin
changed the title
yuelinxin
changed the title
| @@ -2,16 +2,16 @@ | |||
|
|
|||
| ### Key review | |||
|
|
|||
| - A heap is a complete binary tree, which can be divided into a max heap and a min heap based on its property. The top element of a max (min) heap is the largest (smallest). | |||
| - A heap is a complete binary tree, which can be divided into a max heap and a min heap based on its building property. The top element of a max (min) heap is the largest (smallest). | |||
There was a problem hiding this comment.
optional (this may kind of break the accuracy of the translation but give a bit better clarity):
The translation is accurate but could be refined for clarity. Consider
"A heap is a complete binary tree, which can be divided into a max heap and a min heap based on its building property. The top element of a max (min) heap is the largest (smallest)"
->
"A heap is a complete binary tree that can be categorized as either a max heap or a min heap based on its building property."
| @@ -2,16 +2,16 @@ | |||
|
|
|||
| ### Key review | |||
|
|
|||
| - A heap is a complete binary tree, which can be divided into a max heap and a min heap based on its property. The top element of a max (min) heap is the largest (smallest). | |||
| - A heap is a complete binary tree, which can be divided into a max heap and a min heap based on its building property. The top element of a max (min) heap is the largest (smallest). | |||
| - A priority queue is defined as a queue with dequeue priority, usually implemented using a heap. | |||
| - Common operations of a heap and their corresponding time complexities include: element insertion into the heap $O(\log n)$, removing the top element from the heap $O(\log n)$, and accessing the top element of the heap $O(1)$. | |||
There was a problem hiding this comment.
In this sentence we use the plural possessive 'their' but we are referring to 'a heap' (which is singular). Change to either
- Common operations of a heap and its corresponding time complexities include:
- Common operations of heaps and their corresponding time complexities
In my opinion, I think the first option is better.
en/docs/chapter_heap/summary.md
Outdated
| - Top-k is a classic algorithm problem that can be efficiently solved using the heap data structure, with a time complexity of $O(n \log k)$. | ||
|
|
||
| ### Q & A | ||
|
|
||
| **Q**: Is the "heap" in data structures the same concept as the "heap" in memory management? | ||
|
|
||
| The two are not the same concept, even though they are both referred to as "heap". The heap in computer system memory is part of dynamic memory allocation, where the program can use it to store data during execution. The program can request a certain amount of heap memory to store complex structures like objects and arrays. When these data are no longer needed, the program needs to release this memory to prevent memory leaks. Compared to stack memory, the management and usage of heap memory need to be more cautious, as improper use may lead to memory leaks and dangling pointers. | ||
| The two are not the same concept, even though they are both referred to as "heap". The heap in computer system memory is part of dynamic memory allocation, where the program can use it to store data during execution. The program can request a certain amount of heap memory to store complex structures like objects and arrays. When these data are no longer needed, the program needs to release this memory to prevent memory leaks. Compared to stack memory, the management and usage of heap memory demands more caution, as improper use may lead to memory leaks and dangling pointers. |
There was a problem hiding this comment.
Although 'data' is plural, we are referring to one 'set' of data so the sentence 'When these data are no longer needed' sounds very strange to me. I think 'When this data is no longer needed...' sounds much more natural.
This is one of the many strange quirks of the English language, I know this must seem strange for ESL speakers but 'data' should be treated as a singular unit. Would love to hear any thoughts on this
If this pull request (PR) pertains to Chinese-to-English translation, please confirm that you have read the contribution guidelines and complete the checklist below:
If this pull request (PR) is associated with coding or code transpilation, please attach the relevant console outputs to the PR and complete the following checklist: