Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Swap Filenames" only works if the file extensions don't match. #10

Open
DeeGeeFi opened this issue Feb 6, 2021 · 6 comments
Open

"Swap Filenames" only works if the file extensions don't match. #10

DeeGeeFi opened this issue Feb 6, 2021 · 6 comments

Comments

@DeeGeeFi
Copy link

DeeGeeFi commented Feb 6, 2021

If I have two matching .webm files and want to switch the names around (in the same folder), the "Swap filenames" button doesn't seem to do anything. If I have .mp4 and a .webm then the "Swap filenames" seems to work.

Is the swap filenames function trying to do the name change without first naming the other file to some temporary name? That obviously would cause a problem with having two identically named files in the same folder.

@DeeGeeFi
Copy link
Author

DeeGeeFi commented Feb 6, 2021

Additionally it fails silently and only changes in the program UI, so you will delete the incorrect file after "switchin" the names.

@speedheathenULTRA
Copy link

I seriously hope this is NOT THE CASE. If so I've deleted thousands of irreplaceable videos. @DeeGeeFi can you comment? @kristiankoskimaki how about you?

@DeeGeeFi
Copy link
Author

I can't actually confirm it. I think it only happens on a folder that has thousands of files, and even then bit randomly (and it's a old HDD). On a folder that has under 50 files it seems to work correctly. (at least with the small testing I did)

I wonder if it's possible that because the folder has such many files, that the renaming doesn't happen fast enough or in correct order? I'm not sure how Windows 10 file system handles it.

@speedheathenULTRA
Copy link

@DeeGeeFi I just got finished testing this with 5 different sets of files varying in container extension ie. mov, mp4, m4v, etc.

In all tests I was successfully able to rename the files and also rename them back as well as delete the proper file.

@Geekbot2
Copy link

This must happen because when changing the names being in the same folder, the system detects that there is already a file with that name, what must be done in this case is to change the name of a file temporarily to a file name that does not exist in that folder and then do the name exchange.

Example :
"file 1"
"file 2"

I want to swap the "file 1" and "file 2"
If I try to change the name of "file 1" to the name "file 2" I will not be able to because there is already another file with the name "file 2".

@DeeGeeFi
Copy link
Author

I actually took a look at the code (with my very very limited skills) and it tries to do just that. It tries to rename the other file to "VidupeRenamedVideo.avi" and then do the name swap. But I guess it sometimes fails, because I have one of those files still in the folder I used Vidupe on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants