-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
k8s deploy/delete scripts #2
base: master
Are you sure you want to change the base?
k8s deploy/delete scripts #2
Conversation
You can remove manifests/extras/nginx. It is not working and nobody is using it. Assigned you the relevant Jira ticket. |
Why did you rename |
"Removed deprecated warnings" - Is that achieved through the removal of the "beta." prefix? |
delete () { | ||
echo "Deleting sock-shop namespace resources" | ||
kubectl delete all --all -n sock-shop | ||
kubectl delete namespace sock-shop || true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does the || true
do?
If the delete operation fail, why would we want to suppress the error?
echo "Deploying sock-shop namespace" | ||
kubectl create -f manifests/sock-shop-ns.yaml | ||
|
||
echo "Deploying sock-shop core" | ||
kubectl apply $(ls manifests/*[[:digit:]]*.yaml | awk ' { print " -f " $1 } ') | ||
|
||
echo "Deploying sock-shop-mizu extras" | ||
kubectl apply $(ls manifests/extras/*[[:digit:]]*.yaml | awk ' { print " -f " $1 } ') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
echo "Deploying sock-shop namespace" | |
kubectl create -f manifests/sock-shop-ns.yaml | |
echo "Deploying sock-shop core" | |
kubectl apply $(ls manifests/*[[:digit:]]*.yaml | awk ' { print " -f " $1 } ') | |
echo "Deploying sock-shop-mizu extras" | |
kubectl apply $(ls manifests/extras/*[[:digit:]]*.yaml | awk ' { print " -f " $1 } ') | |
echo "Deploying sock-shop" | |
kubectl create -f complete-demo.yaml |
In principal this PR should have been several PRs. (Fix warnings, remove NGINX, add scripts). |
Document script usage in one of the markdown files. |
@gustavomassa @nimrod-up9 any update on this PR? |
@gustavomassa @nimrod-up9 - any update? |
I don't have any more comments besides what I already wrote. Waiting for the fixes/answers. |
btw, who requested this? We have gone a long time without merging this branch. Is it still necessary or should we close without merging? |
Created a script to deploy sock-shop to kubernetes minikube/cluster
Created a script to delete all sock-shop/monitoring/default resources of kubernetes cluster
Renamed nginx-ingress-controller to not deploy it automatically
Removed deprecated warnings
TODO: Figure out how to port-forward/expose Grafana/Prometheus services on the real cluster