Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove comments from files; minify files #8

Open
necolas opened this issue Aug 28, 2020 · 1 comment
Open

Remove comments from files; minify files #8

necolas opened this issue Aug 28, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@necolas
Copy link

necolas commented Aug 28, 2020

I opened an issue about this against the GitHub action preactjs/compressed-size-action#39, but since this is the module that is reading files from disk, it might need to be solved here.

It also doesn't look like the file are being minified before compression?

Maybe allow consumers of this plugin to provide a preprocessor function to run over files before the compression is applied, that way we can strip comments and minify code first.

@issue-label-bot issue-label-bot bot added the bug Something isn't working label Aug 28, 2020
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label bug to this issue, with a confidence of 0.54. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant