Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError: '>=' not supported between instances of 'NoneType' and 'int' #416

Open
linuxdood opened this issue Mar 10, 2024 · 9 comments
Open

Comments

@linuxdood
Copy link

linuxdood commented Mar 10, 2024

Followed the instructions from the README.md for the setup of the package. Had some errors when installing some of the packages due to 'environment managed externally' messages, but I believe those are worked out and not part of the issue I am having. This is capture is from an Arch Linux setup, and further confirmed with same error on a MacBook.
I get the first 2 parts of the output, but errors for the last part :
NBA-ML-output

Suggestions? I messed around in the code to try and Try/Except trap the error, but without success.

@Shanna3229
Copy link

I'm on WSL after getting thrown the "cannot parse keras metadata model" error on windows 10. I was getting the same error as linuxdood once run on WSL so I changed the Kelly_Criterion.py as saqib772 specified. Now I'm getting this:
image
I'll start going through the calls to make exceptions tomorrow since it has taken me a while to get to this point tonight, but just wanted to give the update.

@Scandianis
Copy link

This is working for me:

image

@Shanna3229
Copy link

@saqib772 @Scandianis
Scandianis' is working for me now too, but I don't know if that's just because it's no longer returning None for the OU on any of the games. Will have to see how it does next time that happens but thanks for both your help :)

@linuxdood
Copy link
Author

linuxdood commented Mar 12, 2024

@Shanna3229 is correct - I also believe now that SOME of the sites are not returning the data or some of the data.
I initially tested with fanduel and draftkings since those are the books I use. When they both failed, on a a whim, I tried wynn as well, and it failed with this error as well. So i thought it was code related. After reading @Shanna3229's comment, I tried every book, and low and behold, betmgm, pointsbet and bet_rivers_ny WORKED! It just so happens that I managed to hit the 3 that didn't provide the required data and caused the error.
I have made the code adjustments and now it executes flawlessly - it simply does not provide EV information when the data is incomplete.
SUGGESTION : Perhaps include a statement when displaying the information " *** The EV values are incalculable due to incomplete information from the Odds provider (try another book : fandual, draftkings, betmgm, points bet, wynn, bet_rivers_ny) ***" ?

Thank you for your efforts.

@linuxdood
Copy link
Author

I am unsure if I should close this issue, not sure if I leave it here to remind to have this code correction merged into the package and if the suggesting of posting a message about incomplete data from Odds provider should be added to output?

Please advise.

Cheers.
-y

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants
@Shanna3229 @Scandianis @linuxdood and others