Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix logging race #45

Merged
merged 6 commits into from
Aug 25, 2023
Merged

Attempt to fix logging race #45

merged 6 commits into from
Aug 25, 2023

Conversation

jopemachine
Copy link
Member

@jopemachine jopemachine commented Aug 23, 2023

I'm trying to fix the logging race occurred when integrating raftify with Backend.AI, but it is still incomplete method currently.

@jopemachine
Copy link
Member Author

I think the best solution at this point is to write the slog log to a file instead of standard output, so that it doesn't compete with the Python logger at all.

Writing a PyMutex binding to check if slog's standard output is locked every time in Python is too overheady, requires fixing every Python log call to an asynchronous function, and is unnecessary, in my opinion.

@jopemachine jopemachine marked this pull request as ready for review August 25, 2023 03:09
@jopemachine jopemachine merged commit e48dc7b into main Aug 25, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant