Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add video and audio datatypes #22

Merged
merged 4 commits into from
Jan 12, 2023

Conversation

alexandredljn
Copy link
Contributor

@alexandredljn alexandredljn commented Jan 10, 2023

Description

Grouping of these two issues because there is a lot of code in common:
-Add audio datatype to the project and on it's items
-Add video datatype to the project and on it's items

This pull request contains the front and back code to implement these two tickets

Closes #(17)
Closes #(16)

Type of Change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

To test Audio

  • Create a new project locally from the ui.
  • Add your own configuration with project type "Audio" or use this configuration file
  • Add your own items or use the items used to develop this feature
  • You can test that it works in the annotation page of your newly created project

To test Video

  • Create a new project locally from the ui.
  • Add your own configuration with project type "Video" or use export-test Video-2023-01-10T14_39_56+01_00Z.zip
  • Add your own items or use the items used to develop this feature
  • You can test that it works in the annotation page of your newly created project

Checklist: (Feel free to delete this section upon completion)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My code follows the style guidelines of this project (I have run yarn lint)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (I have run yarn test)
  • My changes generate no new warnings

@alexandredljn alexandredljn added the enhancement New feature or request label Jan 10, 2023
@alexandredljn alexandredljn self-assigned this Jan 10, 2023
@@ -23,6 +28,13 @@ const getInstance = (props = {}) => (
</ThemeProvider>
)

jest.mock('react-i18next', () => ({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: this could be abstracted in a setting to be used everywhere in the project.

Implementation from another project:
../__mocks__/react_i18nextMock.js :

module.exports = {
	useTranslation: () => ({
		t: key => key,
		i18n: {
			changeLanguage: () => new Promise(() => {}),
		},
	}),
	initReactI18next: {
		type: '3rdParty',
		init: jest.fn(),
	},
}

documentation: https://jestjs.io/docs/manual-mocks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created an issue to do this in another commit

annotto-front/src/shared/enums/projectTypes.js Outdated Show resolved Hide resolved
@alexandredljn alexandredljn changed the title Feat/add video and audio datatypes feat: Add video and audio datatypes Jan 11, 2023
@manodupont manodupont merged commit 5e396ea into main Jan 12, 2023
ljndev pushed a commit that referenced this pull request Jan 12, 2023
# [1.1.0](v1.0.13...v1.1.0) (2023-01-12)

### Features

* Add video and audio datatypes ([#22](#22)) ([5e396ea](5e396ea))
@ljndev
Copy link
Collaborator

ljndev commented Jan 12, 2023

🎉 This PR is included in version 1.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants