-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add video and audio datatypes #22
Conversation
annotto-front/src/modules/project/components/common/AnnotationItemWrapper.js
Outdated
Show resolved
Hide resolved
annotto-front/src/modules/project/components/common/AudioItem.js
Outdated
Show resolved
Hide resolved
annotto-front/src/modules/project/components/common/VideoItem.js
Outdated
Show resolved
Hide resolved
@@ -23,6 +28,13 @@ const getInstance = (props = {}) => ( | |||
</ThemeProvider> | |||
) | |||
|
|||
jest.mock('react-i18next', () => ({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: this could be abstracted in a setting to be used everywhere in the project.
Implementation from another project:
../__mocks__/react_i18nextMock.js
:
module.exports = {
useTranslation: () => ({
t: key => key,
i18n: {
changeLanguage: () => new Promise(() => {}),
},
}),
initReactI18next: {
type: '3rdParty',
init: jest.fn(),
},
}
documentation: https://jestjs.io/docs/manual-mocks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created an issue to do this in another commit
annotto-front/src/modules/configurationProject/components/ConfigStepPage.js
Outdated
Show resolved
Hide resolved
annotto-front/src/modules/project/components/common/__tests__/VideoItem.test.js
Outdated
Show resolved
Hide resolved
…nd Video Item component
# [1.1.0](v1.0.13...v1.1.0) (2023-01-12) ### Features * Add video and audio datatypes ([#22](#22)) ([5e396ea](5e396ea))
🎉 This PR is included in version 1.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Description
Grouping of these two issues because there is a lot of code in common:
-Add audio datatype to the project and on it's items
-Add video datatype to the project and on it's items
This pull request contains the front and back code to implement these two tickets
Closes #(17)
Closes #(16)
Type of Change
How Has This Been Tested?
To test Audio
To test Video
Checklist: (Feel free to delete this section upon completion)
yarn lint
)yarn test
)