Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port OpenSSL code to use contemporary API #61

Open
abbra opened this issue Sep 29, 2018 · 10 comments
Open

Port OpenSSL code to use contemporary API #61

abbra opened this issue Sep 29, 2018 · 10 comments

Comments

@abbra
Copy link

abbra commented Sep 29, 2018

Port Jose code to use contemporary OpenSSL API, allowing to use external engines and algorithms provided by them.

@lumag
Copy link

lumag commented Sep 30, 2018

It looks like JOSE already uses EVP API, as you suggested. The major place which can not do that is JWK support. You have to define/specify new JWK types and add functions to convert them to/from EVP_PKEY.

@abbra
Copy link
Author

abbra commented Sep 30, 2018

Thanks @lumag. So we would need to extend JWK spec for that, right?

@abbra
Copy link
Author

abbra commented Sep 30, 2018

Namely, https://tools.ietf.org/html/rfc7518 needs to be extended to add GOST to JWA registries

@beldmit
Copy link

beldmit commented Oct 2, 2018

I'm not sure it's so necessary.
RFC 7515 (https://tools.ietf.org/html/rfc7515#section-4), 7516 (https://tools.ietf.org/html/rfc7516#section-4.1.7), 7517 (https://tools.ietf.org/html/rfc7517#section-4.6) specifies attributes x5u/x5c so for some cases we can avoid both hardcoding algorithms identifiers and algorithm-specific attributes.

@simo5
Copy link
Member

simo5 commented Oct 2, 2018

@beldmit amending the "JSON Web Signature and Encryption Algorithms" registry is required to add any algorithm.
x509 certs identifier are optional and not even implemented in many Jose libraries, and they do not influence in any way the algorithm selection.

@beldmit
Copy link

beldmit commented Oct 2, 2018

OK, so it makes sense to start adding new algorithms in JOSE RFCs. But after that we'll have a hardly maintainable case structures that should be converted in pluggable API somewhen.

@sarroutbi
Copy link
Collaborator

@beldmit , @simo5 : what are the next steps then? Is it necessary to add a new amend to the corresponding RFC?

@beldmit
Copy link

beldmit commented Oct 7, 2021

@sarroutbi I currently don't have plans related to Russian GOST and not aware of similar plans for anybody in Russia. I'm afraid tha library uses a lot of functions deprecated in OpenSSL 3.0 though...

@sarroutbi
Copy link
Collaborator

Hello @beldmit. Thanks for your quick response.

Can this issue be closed then?

@beldmit
Copy link

beldmit commented Oct 7, 2021

Unfortunately, no. Did you try compile your library against openssl 3.0 with -Wdeprecated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants