Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use HermiteInterpolation instead of CubicInterpolation along optical axis #24

Open
leon-vv opened this issue Feb 10, 2023 · 2 comments
Open
Labels
long term Nice to have but not immediately relevant

Comments

@leon-vv
Copy link
Owner

leon-vv commented Feb 10, 2023

The interpolation technique used to speed up ray tracing can be improved

@leon-vv leon-vv added the v1.1 label Feb 13, 2023
@leon-vv
Copy link
Owner Author

leon-vv commented Mar 10, 2023

Implemented for radial geometry in aa242f7

Something similar should be possible for 3D.. research needed

@leon-vv
Copy link
Owner Author

leon-vv commented Mar 19, 2023

Mhh, I think the same thing is possible in 3D, except that only the second derivatives are known (not the first derivatives). This makes the implementation considerably more sketchy, as we need to extract the first derivative using a finite difference method. The accuracy gains would then not be as obvious.

To properly implement this, we need a validation showing us:

  • The interpolation accuracy, as a function of the number of samples along the optical axis
  • The accuracy for a regular CubicSpline interpolation
  • The accuracy once we use the information about the second derivatives (using a quintic spline interpolation)

Since this is quite a bit of work, and the ROI is not as obvious, moving this to longterm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
long term Nice to have but not immediately relevant
Projects
None yet
Development

No branches or pull requests

1 participant