Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature suggestion: Invalid syntax red underlining #2

Open
avidrucker opened this issue Feb 12, 2024 · 4 comments
Open

Feature suggestion: Invalid syntax red underlining #2

avidrucker opened this issue Feb 12, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@avidrucker
Copy link
Contributor

May we have added trigger error messages or warnings (aka the red squiggly underline) where instructions or data may have too many or not enough bits? At first, I thought perhaps syntax highlighting could be nice for this, such as making an entire line red if it is unrecognizable and/or possessing of too few or too many bits. After adding and removing bits from different lines, I think that the standard red underlining would be more effective and consistent with VS Code "bad syntax"/"syntax issues" behavior.

Bonus: Currently, lines are highlighted up to 16 bits, which seems appropriate. I believe it would be nice if a line was too many or too few bits that it not receive valid syntax highlighting to indicate that there is an issue (though I think this is a debatable opinion 😄), this would really put the cherry on the top IMO 😉

@lettucegoblin lettucegoblin added the enhancement New feature or request label Feb 19, 2024
@lettucegoblin
Copy link
Owner

This would be amazing. I need to figure out how to separate the .bin/.a languages. it seems like it's done with scopes here

@avidrucker
Copy link
Contributor Author

This could tie into us writing a linter perhaps 🤔 😁

@lettucegoblin
Copy link
Owner

lettucegoblin commented Mar 5, 2024

Right now I have it checking to see if it's a .a/.bin file extension but if you dont have either and set the language to lcc you can write bin and ass right next to eachother LOL. Though having a non .a/.bin file isnt that common.

@avidrucker
Copy link
Contributor Author

@lettucegoblin Shall we mark this as out of scope for now and close, or should we leave it open in case someone wants to take a stab at it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants