Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bseq1_t --> fseq1_t #5

Open
walaj opened this issue Jan 27, 2017 · 3 comments
Open

bseq1_t --> fseq1_t #5

walaj opened this issue Jan 27, 2017 · 3 comments

Comments

@walaj
Copy link

walaj commented Jan 27, 2017

Hi Heng,
In trying to link bwa and fml in the same executable, I ran into an issue where bseq1_t was defined differently in each library. I ended up making a fork that fixed this issue for SeqLib, but am getting some feedback that it would be better to avoid having multiple fml / bwa clones out there and instead just have SeqLib link to the official fml.

Would you be willing to consider a PR that does the minimal amount of re-naming within fml to be able to link to bwa without multiple definition errors?

@tillea
Copy link

tillea commented Feb 2, 2017

Hi,
the following patch fixes the said issue (leaving others I'll discuss with walaj ).
Hope this helps, Andreas.

@tillea
Copy link

tillea commented Feb 12, 2017

Just to let you know: I have uploaded the patched fermi-lite to Debian experimental. It mighht be tested there and if no issues occure this will be moved into main Debian. It would be great if you could take this over into your next release to avoid diversion.

@tillea
Copy link

tillea commented Oct 25, 2018

Please note: This is fixed by commit e93040b. I have no idea why gitlab merged two different commits to one single pull request. The other commit is addressing #11 .
These two commits resolve the coding patches that were applied to the Debian packaging to avoid conflicts with other packages. It would be great if you could apply these and tag a new version.
Thanks, Andreas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants