Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Single quotes break Boost program options #642

Closed
briadam opened this issue Sep 28, 2017 · 2 comments
Closed

Single quotes break Boost program options #642

briadam opened this issue Sep 28, 2017 · 2 comments

Comments

@briadam
Copy link
Contributor

briadam commented Sep 28, 2017

On the dev branch, using single quotes around booleans, strings, and sets breaks input file parsing when using Boost program options. This is counter to the input file changes of @dmcdougall in #457 See the discussion in #640, where @roystgnr asserts that reverting #457 is likely okay.

Specifically these tests break:

  • FAIL: test_BoostInputOptionsParser
  • FAIL: test_intercomm0/test_intercomm0_gravity_run.sh
  • FAIL: t01_valid_cycle/rtest01.sh
  • FAIL: test_mala
@dmcdougall
Copy link
Member

Does removing the quotes produce a file that is acceptable by both BPO and GetPot?

briadam added a commit to briadam/queso that referenced this issue Sep 29, 2017
@briadam
Revert quotes in input files that can foil Boost prog opts
6391f8b 
Partially addresses libqueso#642 by partially reverting
  "Make boost po opt-in, convert all test input files to getpot format"

This reverts the input files modified in
  commit 00477bd.

Conflicts:
	configure.ac
This was referenced Sep 29, 2017
Merged
Merged
@briadam
Copy link
Contributor Author

briadam commented Sep 29, 2017

Resolved by #644

@briadam briadam closed this as completed Sep 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dmcdougall @briadam