Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FieldFilter to Delete and Put #20

Open
5 tasks
Adphi opened this issue Jul 24, 2021 · 1 comment
Open
5 tasks

Add FieldFilter to Delete and Put #20

Adphi opened this issue Jul 24, 2021 · 1 comment
Assignees
@Adphi
Labels
enhancement New feature or request good first issue Good for newcomers priority/high
Milestone
v1

Comments

@Adphi
Copy link
Member

Adphi commented Jul 24, 2021 •
edited
Loading

Expected behaviour:

  • Put without FieldFilters and ID field not present: error
  • Put with FieldFilters and ID field not present: update all FieldMask fields of messages matching filters
  • Put with FieldFilters and ID field present: update all FieldMask fields of messages matching filters
  • Delete without FieldFilters and without ID field: error
  • Delete with FieldFilters and without IDfield: delete all matching
@Adphi Adphi added this to the v1 milestone Jul 24, 2021
@Adphi Adphi self-assigned this Jul 24, 2021
@Adphi
Copy link
Member Author

Adphi commented Jul 24, 2021

Maybe this should be handled by creating two more methods:

  • PatchAll
  • DeleteAll

@Adphi Adphi added enhancement New feature or request good first issue Good for newcomers labels Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Adphi Adphi

Labels
enhancement New feature or request good first issue Good for newcomers priority/high
Projects
None yet
Milestone
v1
Development

No branches or pull requests
1 participant
@Adphi