Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This method does not corresponds to OrDefault methods convention #51

Open
Konard opened this issue Mar 19, 2021 · 0 comments
Open

This method does not corresponds to OrDefault methods convention #51

Konard opened this issue Mar 19, 2021 · 0 comments

Comments

@Konard
Copy link
Member

Konard commented Mar 19, 2021

IO/csharp/Platform.IO/FileHelpers.cs

Line 44 in 00ac8c5

throw new InvalidOperationException($"File is not aligned to elements with size {elementSize}.");

By the convention all methods ended with OrDefault are expected to return default value in any unexpected case. Such methods are not expected to throw exceptions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Konard