Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileSystemProvider (FTP) wrongly returns size as string and not number #56

Closed
bpasero opened this issue Apr 26, 2019 · 3 comments
Closed

Comments

@bpasero
Copy link

bpasero commented Apr 26, 2019

Heads up, found this while looking into microsoft/vscode#72909. The FTP provider seems to return FileStat where size is of type string but not number.

image

@gjsjohnmurray
Copy link

@liximomo I think the fix needs to go here (code pointer)

Insert this clause (or similar):

    if (typeof target.size === 'string') {
      target.size = +target.size;
    }

@liximomo
Copy link
Owner

liximomo commented Apr 27, 2019 via email

@liximomo
Copy link
Owner

Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants