Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation] Encode rules for skeleton, asserts, unrecheable, testing, etc #620

Open
bcardosolopes opened this issue May 20, 2024 · 3 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@bcardosolopes
Copy link
Member

bcardosolopes commented May 20, 2024

Inspired by @Lancern work on providing some ASM guideline goodness, I created some guidelines for auto and camelCase usage, see it here: https://llvm.github.io/clangir/GettingStarted/coding-guideline.html

However, we still need to encode the other common review items, such as OG skeleton, asserts, unrecheable, testing, etc. It'd be nice to have that.

@bcardosolopes
Copy link
Member Author

@bcardosolopes bcardosolopes added documentation Improvements or additions to documentation enhancement New feature or request labels May 20, 2024
@eZWALT
Copy link
Contributor

eZWALT commented Jun 10, 2024

Inspired by @Lancern work on providing some ASM guideline goodness, I created some guidelines for auto and camelCase usage, see it here: https://llvm.github.io/clangir/GettingStarted/coding-guideline.html

However, we still need to encode the other common review items, such as OG skeleton, asserts, unrecheable, testing, etc. It'd be nice to have that.

Would it make sense If I presented a proposal of Dialect intermixing guidelines? I'm guessing it could be useful for other future contributors which for instance, might want to tackle OpenACC.

@bcardosolopes
Copy link
Member Author

That'd be great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants