Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Equal heights: improvements #109

Open
msayoung opened this issue Sep 15, 2022 · 4 comments
Open

Equal heights: improvements #109

msayoung opened this issue Sep 15, 2022 · 4 comments
Assignees

Comments

@msayoung
Copy link
Member

msayoung commented Sep 15, 2022

These are my questions - I think we need some testing to answer.


Do we want this to be togglable?


I think we should not apply this to single column layouts.


Is there a case for making all things that behave in this way be the same height as eachother?

Would it make sense, in that case, to add an .equal-heights class to the paragraphs we want to target? This might make it easier for other people to utilise later in a sub-theme, or us to turn on and off if we want to.


Finally - in testing I notice that if I use a 3-column layout, and put two IA blocks in each they are all the same height as eachother. If I were to want them to be the same height per row I would need to make a new row. I think this is fine, but we'll need to document it well and add some good help text.

@msayoung
Copy link
Member Author

Sometimes, I'll need to work out when, the equal heights needs a refresh to work.

@markconroy
Copy link
Member

I had the same issue on a website recently. I set the function to use a setTimeout of 100ms and that solved it. It was because images are getting loaded after the HTML gets rendered (I think).

@markconroy
Copy link
Member

@msayoung I think we should have a call about this ticket. The item to not have it apply to single column layouts is fine, but the others will requite a bit of chatting.

@msayoung
Copy link
Member Author

msayoung commented Nov 2, 2022

I think we should put this in the Maybe later column and take feedback on how its behaving. I'm used to it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Sprint 13/14 backlog
Development

No branches or pull requests

3 participants