Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chapter 10: Possible error found within the code of method fixTreeProperties(node) on page 264 #106

Open
thinktinker opened this issue Sep 15, 2018 · 1 comment
Labels

Comments

@thinktinker
Copy link

The following while condition is not valid as method isRed() shouldn't be invokable through .color.

while (node && node.parent && node.parent.color.isRed() && node.color !== Colors.BLACK){
//rest of the code block in here
}

By the way, I couldn't find the code for chapter 10's RedBlackTree and RedBlackNode anywhere in the downloaded code or in the git repo here. Please advise. Thank You.

@thinktinker thinktinker changed the title Possible error found within the code of method fixTreeProperties(node) on page 264 Chapter 10: Possible error found within the code of method fixTreeProperties(node) on page 264 Sep 15, 2018
@loiane loiane added the review label Sep 16, 2018
@loiane
Copy link
Owner

loiane commented Sep 16, 2018

@thinktinker - thanks for opening the issue. I'll review it and get back to you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants