Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How about support for xstate@4? #43

Open
karfau opened this issue Jun 20, 2020 · 2 comments
Open

How about support for xstate@4? #43

karfau opened this issue Jun 20, 2020 · 2 comments

Comments

@karfau
Copy link

karfau commented Jun 20, 2020

While trying to add a test for #40 I realized that the state machine I describe in #38 is not valid vor xstate@3 but only for v4.

Updating to version 4 makes the download test fail with a message that I fixed in one of the recent PRs.

If we still want to support both version 3 and 4 we could at least start a xstate@4 branch to start working on it (and release them as prereleases?).
Or maybe there is a way to test against both version 3 and 4 on CI, any ideas?
(Just updating as part of CI might not work since not all machines work for both versions.)

I think for the users they will only have machines for one version, so they don't have that issue.

@karfau
Copy link
Author

karfau commented Jun 20, 2020

As you can see I added a POC to solve that issue to #40 .
I can easily extract those changes into different PRs if you want.
Please let me know what you think.
(My inspiration was this article: https://dev.to/joshx/test-your-npm-package-against-multiple-versions-of-its-peer-dependency-34j4 )

@karfau
Copy link
Author

karfau commented Nov 6, 2020

FYI: since there was no response in this repo since I created the issue and PRs, I have now decided to focus on maintaining my fork. This leads to the fact that the branches are starting to contain more things then makes sense in this repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant