Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test cases #1

Closed
22 tasks done
luizbarboza opened this issue Oct 13, 2022 · 2 comments
Closed
22 tasks done

add test cases #1

luizbarboza opened this issue Oct 13, 2022 · 2 comments

Comments

@luizbarboza
Copy link
Owner

@Peque
Copy link

Peque commented Nov 5, 2022

@SBanksX Did you run any performance tests after fixing all those floating point issues? I'd be interested in knowing how this implementation compares to https://github.com/mfogel/polygon-clipping.

Of course I can run the tests myself, but I am guessing there is a high chance you run them already while or after implementing the changes. 😊

@markstos
Copy link

markstos commented Aug 2, 2023

@Peque Many of the tests come from the polygon-clipping library, which crashes on the test cases, so it doesn't matter if polygon-clipping is faster if it doesn't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants