Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variant ID #42

Open
discoveryjames opened this issue Jun 30, 2019 · 1 comment
Open

Variant ID #42

discoveryjames opened this issue Jun 30, 2019 · 1 comment

Comments

@discoveryjames
Copy link

I believe each variant should have a unique id, the example code doesn't suggest assigning a new id each each variant. I'm aware there is a item_group_id, but I believe that that the id should also be unique. It overrides the previous entry with that id if not I think.

Am I missing something or should $variant->id() be used for each variant?

@Fredyy90
Copy link
Contributor

exactly this, set a new id for your variant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants