-
Notifications
You must be signed in to change notification settings - Fork 711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] TF Backend Regularization fix. #1781
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check the [docs](https://www.tensorflow.org/api_docs/python/tf/keras/regularizers/L1) and the argument is of the form l1/l2 instead of just l in the current version.
lululxvi
reviewed
Jun 20, 2024
lululxvi
reviewed
Jun 20, 2024
lululxvi
reviewed
Jun 20, 2024
lululxvi
reviewed
Jun 20, 2024
Split the regularization and model save into two PRs. |
Made capital and added support for passing in either lower/uppercase for the regularizer name.
using .lower() instead of adding multiple checks for readability.
Will split into a new commit
Remove comments
Linter said so
g-w1
pushed a commit
to g-w1/deepxde
that referenced
this pull request
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TF Regularization
Check the docs and the argument for
tf.keras.regualizers.l1/l2
is of the forml1
/l2
instead of justl
in the current version. Without it this breaks:Specifically it gives you the error:
As of right now, the following works instead:
But merging would allow for each one to be used on their own.