PROXY as global in http.lua

[svarogg]

Line 189 and 201 uses global variable PROXY.
It breaks my tests as I am using a strict globals checker to make sure no globals were declared.
This was fixed 5 Jul 2013 in 1f9ccb2 but the patch was not released as a rock yet.

Since latest release(v3.0-rc1) was quite some time ago - 14 Jun 2013, when can I expect a new release that fixes that issue?

[diegonehab]

I don't have an answer for this question. There are a few outstanding problems that make me unwilling to release a final version. Unfortunately, I don't have the manpower to work on them at the moment. I'd love some help.

[svarogg]

I will try to see what I can do, and if I have enough knowledge to try fix those things myself.
Please let me know what are the burning issue.

[catwell]

Same here. What major issues prevent a release?

EDIT - related: #51 and #93

Looking at GitHub issues, the only release blockers I could find are #83 and maybe #99.

In pull requests, I think:

• could be trivially merged: fix use of global #86 the universe has only existed for 43.8 years #84 Added ability to set the option reuseport of a tcp socket. #79
• look good to me: Generate headers before proxy changes host and port #96 fix build with uClibc without IPv6 #90
• needs extra work: Added a fix for properly reporting CONNRESET. #81
• no idea: Freebsd unix socket support #101 and Modify http.lua to do a host lookup first, to determine the right address family to use (previously tcp was the default). #91 (related to issue socket.http does not work with IPv6 servers #83)
• do not block release IMO: Move #define WAITFD_* to .h #80 Publish API used by luasec #72 support for intermediate filters in ltn12.pump.all #66 Change. socket:setfd() set fd to invalid value.  #54

[daurnimator]

@diegonehab do you have time to review/merge the pull requests @catwell mentioned?

[jjvbsag]

👍 For now I have to patch all occurrences of http.lua I find (e.g. in ZeroBrane Studio). I'd prefer a released version with the fix

[diegonehab]

Which one are you taking about? The HTTP proxy one 110? Although it is open, isn't the code merged anyway? The uClibc one (#90) has conflicts. If it is adjusted and tested, I can merge. I need someone to take charge of #81 and test it properly, as it seems to be a delicate change. #101 is not a big deal, and if somebody tests it I can also merge.

[diegonehab]

@jjvbsag ?

[jjvbsag]

Sorry, was busy on the job...
This is the patch, I'm talking about:

--- http.lua.orig	2018-11-03 10:54:52.997376028 +0100
+++ http.lua	2018-11-03 10:55:33.496561255 +0100
@@ -186,7 +186,7 @@
 local function adjusturi(reqt)
     local u = reqt
     -- if there is a proxy, we need the full url. otherwise, just a part.
-    if not reqt.proxy and not PROXY then
+    if not reqt.proxy and not _M.PROXY then
         u = {
            path = socket.try(reqt.path, "invalid path 'nil'"),
            params = reqt.params,
@@ -198,7 +198,7 @@
 end
 
 local function adjustproxy(reqt)
-    local proxy = reqt.proxy or PROXY
+    local proxy = reqt.proxy or _M.PROXY
     if proxy then
         proxy = url.parse(proxy)
         return proxy.host, proxy.port or 3128

See also pkulchenko/ZeroBraneStudio#950 for how to reproduce
(the second issue mentioned there is already fixed in your master)

---

About testing. For me it is all about a project on an ARM target. I am willing to try anything there, but as the project time line is extremely tight I can make no promises about when...

[diegonehab]

This seems to be in master for a long, long time. Since 2013, actually. Maybe this is a problem of releasing a new tag so distributions can pull from?

[ewestbrook]

Will the tagging of a new release solve this problem?

We're reviewing open items in preparation for a release. If action is needed here, please add a comment. Otherwise, this issue will be closed on or after 24-Feb-2019.

Thanks!

[jjvbsag]

Hi! Its in the master branch, so releasing a new tagged version seems fine for me...
Regards

[catwell]

This issue has been fixed for a long time and a release has been shipped since then, closing.