Skip to content
This repository has been archived by the owner on Apr 27, 2023. It is now read-only.

Fix the Storybook setup with Saka #65

Open
pureooze opened this issue Jul 26, 2018 · 2 comments
Open

Fix the Storybook setup with Saka #65

pureooze opened this issue Jul 26, 2018 · 2 comments
Labels
Milestone

Comments

@pureooze
Copy link
Member

A while back I added Storybook support for Saka but it never fully worked. There were issues with missing css (like icons) as well as some issues with mocking the browser APIs when rendering certain components. On top of that the storybook build ended up breaking when I upgraded the project to Webpack 4.

I have managed to get most of the stuff mentioned above working in a branch here: https://github.com/pureooze/saka/tree/storybook-fix

There are however still some minor issues to iron out so this issue is to keep track of the work to get Storybook working again. I also thought this would be a good way for others to provide suggestions/feedback for how Storybook should be used with Saka.

@pureooze pureooze added this to the 0.17.0 milestone Aug 27, 2018
@pureooze
Copy link
Member Author

Since we use Webpack 4 we will need to wait till Storybook hits 4.0 for compatibility.

@pureooze
Copy link
Member Author

pureooze commented Sep 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant