Refactor Saka search modes to use React best practices

[pureooze]

Saka currently relies on mode specific providers and "dumb" components to render search results for the selected mode. We currently define a "dumb" component for each search mode. This is done so that we can set certain things like the icon and color for each suggestion as they differ between each type of suggestion.

We should refactor Saka to have a single generic suggestion component that accepts props that define all the suggestion specific parameters.

The refactoring will make the code a lot easier to understand and maintain.

Some related docs:
https://reactjs.org/docs/composition-vs-inheritance.html
https://reactjs.org/docs/components-and-props.html

[eejdoowad]

Just FYI, I’ve already begun and mostly completed this in the branch remove-mwc. It still has quite a bit of work to be done, but I’ll get something PR worthy in by Saturday.

[pureooze]

Awesome 😃 ! Don't feel rushed to get it in, I think this type of refactor definitely benefits from careful evaluation of all the possible solutions.

[eejdoowad]

So.... I got sidetracked and never got a chance to work on this, and probably won't for a while. I've pushed what I had at the time to remove-mwc. It may or may not be useful.