Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: named exports for v5 compatibility #292

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: named exports for v5 compatibility #292

wants to merge 1 commit into from

Commits on May 24, 2021

  1. fix: named exports for v5 compatibility 

    The change from module.exports to export default no longer allows you to use named imports. This would be a breaking change, but it's also incompatible with the current type declarations.

This could be fixed using commonjs module and 'export =' in TypeScript, but this is incompatible with Rollup. The simplest answer seems to be just explicitly using named exports based on the type declarations as well as including the default export.
    @ajcrites
    ajcrites committed May 24, 2021
    Configuration menu
    Copy the full SHA
    3e874e0 View commit details
    Browse the repository at this point in the history