Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fatal errors shut down the console #5

Open
stelcheck opened this issue May 16, 2017 · 4 comments
Open

fatal errors shut down the console #5

stelcheck opened this issue May 16, 2017 · 4 comments
Assignees

Comments

@stelcheck
Copy link
Member

Instead, we should:

  1. Stop the worker
  2. Wait for file save to attempt restart

cc @ronkorving

@stelcheck stelcheck self-assigned this May 16, 2017
@stelcheck
Copy link
Member Author

@ronkorving would love to hear from you how I could do this. Basically, I am looking for a way to have the master suspend restarts on crashes.

Note to myself: this would also require moving the file watch logic in the master process.

@stelcheck
Copy link
Member Author

@ronkorving any suggestions?

@ronkorving
Copy link
Member

Not yet, sorry. I'm not forgetting, but this is a tricky one so need to really set aside some time for this.

@stelcheck
Copy link
Member Author

I took some time to look into it. In short, I doubt we could build anything without at least exposing the WorkerManager object instance in the processManager of MAGE.

I can see two approaches which would work:

  1. Block process shutdown of the worker, allowing for post-mortem investigation; the worker would then complete the shutdown once a file would be altered (which I think would be a neat feature).
  2. Let the master catch the failure and control the restart logic.

Let me know if you think this analysis happens to be correct, or feel free to add your own analysis.

stelcheck added a commit to stelcheck/mage-console that referenced this issue Nov 26, 2017
Fixes multiple outstanding issues, and pretifies error output by:

  1. using pretty-error to render the error
  2. stripping part of the stack that really should have no relevance

Fixes mage#4 mage#5 mage#8 mage#9 mage#11
stelcheck added a commit to stelcheck/mage-console that referenced this issue Nov 26, 2017
Fixes multiple outstanding issues, and pretifies error output by:

  1. using pretty-error to render the error
  2. stripping part of the stack that really should have no relevance

Fixes mage#4 mage#5 mage#8 mage#9 mage#11
stelcheck added a commit to stelcheck/mage-console that referenced this issue Dec 6, 2017
Fixes multiple outstanding issues, and pretifies error output by:

  1. using pretty-error to render the error
  2. stripping part of the stack that really should have no relevance

Fixes mage#4 mage#5 mage#8 mage#9 mage#11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants