Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve testing on windows #70

Open
pelletier197 opened this issue May 21, 2022 · 0 comments
Open

Improve testing on windows #70

pelletier197 opened this issue May 21, 2022 · 0 comments

Comments

@pelletier197
Copy link
Collaborator

pelletier197 commented May 21, 2022

Issue #67 revealed an issue with Windows that was not revealed by current unit tests on Linux, and we're interestingly not revealed by unit tests even when running them on windows.

However, the issue was found when running a generate command using the cli. So I see 3 things that could be done:

  • add unit tests for windows in the GitHub actions (and ideally for node 17 as well: right now we test only 16). Make sure the shell used is PowerShell and not bash.
  • find a way that jest can run the tests using node version 16. For some reasons, parts covered by the tests were not failing on windows and they should have. (Reader.spec.ts)
  • run a generate command as a unit test in the pipeline (and maybe do some asserts). This could be considered an integration test of the cli. This one would have failed on windows if it existed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant