Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The "version" field is not typed #258

Open
xiniria opened this issue Oct 2, 2023 · 0 comments · May be fixed by #259
Open

The "version" field is not typed #258

xiniria opened this issue Oct 2, 2023 · 0 comments · May be fixed by #259

Comments

@xiniria
Copy link

xiniria commented Oct 2, 2023

I recently came across an issue when using the MailJet Node SDK, because of the version field in the RequestConfig: I had written '3.1' instead of 'v3.1'. My proposal is to type this field as 'v3' | 'v3.1' to prevent this from happening in the future to other users. I can open a PR.
@xiniria xiniria linked a pull request Nov 27, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update version field typing xiniria/mailjet-apiv3-nodejs
1 participant
@xiniria