Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculation exception for {weighted_average_uplift} function #182

Open
dgliu opened this issue Jun 26, 2022 · 0 comments
Open

Calculation exception for {weighted_average_uplift} function #182

dgliu opened this issue Jun 26, 2022 · 0 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@dgliu
Copy link

dgliu commented Jun 26, 2022

🐛 Bug

To Reproduce

Steps to reproduce the behavior:

When subfunction {response_rate_by_percentile} is executed based on the prediction of a model, if the variable group_size has a value of 0, the variable response_rate will have a value of nan. Finally, function {weighted_average_uplift} will return a nan value.

Expected behavior

Requires additional handling of nan values.

Environment

  • scikit-uplift version (e.g., 0.1.2):
  • scikit-learn version (e.g., 0.22.2):
  • Python version (e.g., 3.7):
  • OS (e.g., Linux):
  • Any other relevant information:

Additional context

@maks-sh maks-sh added bug Something isn't working help wanted Extra attention is needed labels Jun 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants