Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add identifier to MapMatchingResponse #457

Open
1ec5 opened this issue Sep 9, 2020 · 0 comments
Open

Add identifier to MapMatchingResponse #457

1ec5 opened this issue Sep 9, 2020 · 0 comments
Labels
Core improvement Improvement for an existing feature.

Comments

@1ec5
Copy link
Contributor

1ec5 commented Sep 9, 2020

Per mapbox/mapbox-java#1174, the Mapbox Map Matching API will start returning a uuid field for all successful map matching requests. MapMatchingResponse should have an identifier property similar to the existing RouteResponse.identifier property, decoding it when uuid is present in the response.

RouteResponse(matching:options:credentials:) should pass in the value of this new property instead of nil:

self.init(httpResponse: response.httpResponse, identifier: nil, routes: routes, waypoints: waypoints, options: .match(options), credentials: credentials)

Unlike mapbox/mapbox-java#1174, this work is not blocked by deploying the change to all profiles, because the identifier property would be optional.

/cc @mapbox/navigation-ios @danpaz

@1ec5 1ec5 added the improvement Improvement for an existing feature. label Sep 9, 2020
@1ec5 1ec5 added this to the v1.3.0 milestone Oct 16, 2020
@truburt truburt removed this from the e (android-v1.5.0 / ios-v1.3.0) milestone Feb 26, 2021
@truburt truburt added the Core label Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core improvement Improvement for an existing feature.
Projects
None yet
Development

No branches or pull requests

2 participants