From 5d9a7b8c912db61e50ff2fd7a9b4f7d471a2f9d4 Mon Sep 17 00:00:00 2001 From: neodescis Date: Fri, 28 Jun 2024 09:21:48 -0600 Subject: [PATCH] Expose `CANVAS` class in constants (#1184) * Move canvas class name to constants --------- Co-authored-by: Stepan Kuzmin --- src/constants.js | 1 + src/events.js | 2 +- test/utils/key_events.js | 3 ++- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/constants.js b/src/constants.js index c22a18b82..655d16184 100644 --- a/src/constants.js +++ b/src/constants.js @@ -1,4 +1,5 @@ export const classes = { + CANVAS: 'mapboxgl-canvas', CONTROL_BASE: 'mapboxgl-ctrl', CONTROL_PREFIX: 'mapboxgl-ctrl-', CONTROL_BUTTON: 'mapbox-gl-draw_ctrl-draw-btn', diff --git a/src/events.js b/src/events.js index 7915cd130..e21e2b939 100644 --- a/src/events.js +++ b/src/events.js @@ -125,7 +125,7 @@ export default function(ctx) { const isKeyModeValid = code => !(code === 8 || code === 46 || (code >= 48 && code <= 57)); events.keydown = function(event) { - const isMapElement = (event.srcElement || event.target).classList.contains('mapboxgl-canvas'); + const isMapElement = (event.srcElement || event.target).classList.contains(Constants.classes.CANVAS); if (!isMapElement) return; // we only handle events on the map if ((event.keyCode === 8 || event.keyCode === 46) && ctx.options.controls.trash) { diff --git a/test/utils/key_events.js b/test/utils/key_events.js index 0252cbc28..c70fb8299 100644 --- a/test/utils/key_events.js +++ b/test/utils/key_events.js @@ -1,6 +1,7 @@ import createSyntheticEvent from 'synthetic-dom-events'; +import * as Constants from '../../src/constants.js'; -const classList = ['mapboxgl-canvas']; +const classList = [Constants.classes.CANVAS]; classList.contains = function(cls) { return classList.indexOf(cls) >= 0; };