-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure tap-dragging fires an update event #881
Conversation
I also ran into this issue. Can confirm that the fix is working properly. Can it be merged? |
Until such a fateful day, you can workaround this bug as outlined in the PR message:
|
Thanks, yeah I know, but it's always better to have the fix upstream. And it would save time for the next person running into this. |
@karimnaaji: Why was this closed? The issue still remains as far as I can see. |
Oups sorry about that @trygveaa ! We did a change of repository default branch yesterday and github closed all the PRs that were targetting the old branch as default target, this is the only PR we did not reopen. |
Oh, so that's what happened. I did wonder why all my PRs were closed and reopened. You have to change the destination too though. I see you have done it for most, but not all PRs. |
Yep working on it now :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was fixed before, but I will merge it to keep the unit test. Thanks for the contribution @Zirak!
Tap dragging did not fire a
draw.update
event, leading to much confusion.In the interim, a fairly simple fix is to add the following before creating the relevant
MapboxDraw
instance: