Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't depend on old version of dependencies #126

Open
marado opened this issue May 14, 2021 · 1 comment
Open

don't depend on old version of dependencies #126

marado opened this issue May 14, 2021 · 1 comment
Labels
dependencies Pull requests that update a dependency file enhancement
Milestone
0.9.0

Comments

@marado
Copy link
Owner

marado commented May 14, 2021

We're stuck into depending on an old version on strip-ansi, just because npm sucks (more info here: ca64fcd ).

The alternative to this - at least the one I can think of - is to bump up the node engine we depend on to >= 12, but I wasn't at all ready to do that (and drop support to those still not using such a recent version).

However, eventually, with that or another approach, this situation must be resolved.
@marado marado added this to the 0.9.0 milestone May 14, 2021
@marado marado added dependencies Pull requests that update a dependency file enhancement labels May 14, 2021
@marado
Copy link
Owner Author

marado commented Aug 28, 2021

Node.js on the current Debian stable is 12. However, in Ubuntu's LTS version (20.04) it is Node.js 10.
Ubuntu 20.04 EOL is Apr 2025.

@marado marado changed the title don't depend on old version of strip-ansi don't depend on old version of dependencies Aug 28, 2021
marado added a commit that referenced this issue Aug 28, 2021
@marado
Depend on mathjs < 9.4.4
dea6d06 
Not unlike what happened in ca64fcd ,
we must compensate for the deficiencies of npm.

In this case, mathjs 9.4.4 announces support only for node >= 12.
While it actually works on Node 10[1], we don't know for how long, and
so we're depending specificly on a version older than 9.4.4.

We will need to take this into account when dealing with #126 .

[1] josdejong/mathjs#2258
marado added a commit that referenced this issue Oct 5, 2021
@marado
0.6.34: manage dependencies
14fcdfd 
* lowdb has joined the #126 bandwagon: it now depends on node >=12,
  but we still wish to keep supporting node 10;
* regenerating the package-lock.json file also closes #131, bumping
  ansi-regex from 5.0.0 to 5.0.1.
marado added a commit that referenced this issue Feb 5, 2022
@marado
0.6.38: depend on chalk <= 4
3e5a822 
chalk 5 is not retrocompatible (see #137).

For now we are depending on chalk <=4 to fix that, and
Nodiverse >= 0.4.1 (which also depends on chalk <= 4).

In the future we might try to support more recent versions of chalk
too, but that will mean bumping node's dependency to
`"node": "^12.20.0 || ^14.13.1 || >=16.0.0"`, and as we can see in
issue #126 we're still not ready to stop supporting node 10.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file enhancement
Projects
None yet
Milestone
0.9.0
Development

No branches or pull requests
1 participant
@marado