Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to turn off edge outlines in heatmap segments #150

Open
big-o opened this issue Sep 12, 2020 · 2 comments
Open

Option to turn off edge outlines in heatmap segments #150

big-o opened this issue Sep 12, 2020 · 2 comments
Assignees

Comments

@big-o
Copy link

big-o commented Sep 12, 2020

Great library! I've been using it to generate some plots with a background that has a different colour at each corner, and becomes more opaque at the centre.

I've noticed that when you set the alpha to < 1, you start to see the edges around each segment. This creates an unwanted "grid" which is either triangular or hexagonal.

Simply setting the edgecolor to "none" in the ax.fill call in heatmapping.heatmap seems to fix it, and produces a lovely smooth effect.

Can we either get this changed, or make it a configurable option to turn off the edge lines?

@marcharper
Copy link
Owner

So basically you want to be able to pass through arguments to ax.fill ? That seems fine to me.

@big-o
Copy link
Author

big-o commented Sep 13, 2020

Pretty much. I'd argue that defaulting edgecolor to 'none' too would be a better choice than the current default behaviour, but that's a matter of opinion and if we can override then it doesn't really matter anyway.

@marcharper marcharper self-assigned this Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants