Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versioned docker image (and tags) #53

Open
ac-medexter opened this issue Nov 30, 2023 · 3 comments
Open

Versioned docker image (and tags) #53

ac-medexter opened this issue Nov 30, 2023 · 3 comments

Comments

@ac-medexter
Copy link

Could you please add version numbers to your docker tags?

I ask because a few days ago your jdk11 image was silently updated to Chrome 119 and all of our test failed because the chrome driver used was no longer compatible.

I read your argumentation in #2 that tests should always run on the latest chrome version, and I could not agree more to that concept. However we would update our test environment on our pace, and only introduce a new chrome version once our drivers can handle them. With chrome versions persisted in docker images and corresponding tags this controlled updates are possible.

@markhobson
Copy link
Owner

Hi, ChromeDriver is included in this image and is always aligned with the version of Chrome. How comes you're using a different ChromeDriver?

I'm not against tagging images for Chrome versions per se, it's more the extra work to the build process that I'm reluctant to maintain for no real benefit. As a workaround have you considered using digests to fix the image used in your build?

@ac-medexter
Copy link
Author

Thank you for suggesting this workaround, using digests for our image works fine for now.

Our tests use Selenium and included drivers in a legacy package, so far the priority of updating Selenium has been too low for anyone starting on it yet. Therefore I wish we could update the Chrome-JDK image on our own pace. The driver dependencies coming with selenium sadly do not support Chrome v119.

The workaround with digests works fine for us until we update all dependencies in our project, if you wish you can close this Issue now. Although I hope including the chrome version in tags will be coming along sometime.

@markhobson
Copy link
Owner

Glad you can work around it for now. I'll leave this issue open as it's an often requested feature. Personally I doubt I'll invest time in this, but welcome input from those who find it useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants