Refactor adapters #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djhi
reviewed
Jun 7, 2024
djhi
reviewed
Jun 7, 2024
fzaninotto
commented
Jun 7, 2024
| expect(request.status).toEqual(418); | ||
| // @ts-ignore | ||
| expect(request.responseText).toEqual( | ||
| '{"data":[{"id":1,"name":"foo"},{"id":2,"name":"bar"}],"status":200}', | ||
| ); | ||
| }); | ||
|
|
||
| it('should pass request in response interceptor', async () => { |
There was a problem hiding this comment.
This is no longer true
djhi
reviewed
Jun 7, 2024
| const adapter = new MswAdapter({ server }); | ||
| const handler = adapter.getHandler(); | ||
| ``` | ||
|
|
There was a problem hiding this comment.
IMO we should go a bit further and at least mention the required methods of a Server object and their input/output
djhi
reviewed
Jun 7, 2024
README.md
Outdated
| Intercept AJAX calls to fake a REST server based on JSON data. Use it on top of [Sinon.js](http://sinonjs.org/) (for `XMLHTTPRequest`) or [fetch-mock](https://github.com/wheresrhys/fetch-mock) (for `fetch`) to test JavaScript REST clients on the browser side (e.g. single page apps) without a server. | ||
| A browser library that intercepts AJAX calls to mock a REST server based on JSON data. | ||
|
|
||
| Use it on top of [Sinon.js](http://sinonjs.org/) (for `XMLHttpRequest`) or [fetch-mock](https://github.com/wheresrhys/fetch-mock) (for `fetch`) to test JavaScript REST clients on the browser side (e.g. single page apps) without a server. |
djhi
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
To reuse the adapters with a different REST dialect, developers must rewrite everything.
Also, middlewares are adapter-specific.
Solution
Use dependency injection instead of inheritance for server logic.
Rename servers to adapters
TODO