Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

New 100 char display name length limit is too restrictive #5870

Closed
ulope opened this issue Aug 16, 2019 · 10 comments
Closed

New 100 char display name length limit is too restrictive #5870

ulope opened this issue Aug 16, 2019 · 10 comments
Labels
z-p2 (Deprecated Label)

Comments

@ulope
Copy link

ulope commented Aug 16, 2019

Description:

With d16c637 a display name length limit of 100 characters was introduced.

Unfortunately this breaks our (Raiden Network) (admittedly unorthodox) use of the display name field as a way to publish ECDSA (recoverable) signatures.

Hex encoded those take up 132 chars.

We could switch to base64 encoding (which would just fit) or (mis-)use the avatar_url field but both of those would be backwards incompatible changes at our protocol level which we would like to avoid if possible.

So the question is: Is there a possibility of having this length restriction increased (to say 256) or better yet be made configurable?

@turt2live
Copy link
Member

It sounds like you want https://github.com/matrix-org/matrix-doc/issues/489 or matrix-org/matrix-spec-proposals#1769 instead

@aaronraimist
Copy link
Contributor

It probably should still be configurable though

@t3chguy
Copy link
Member

t3chguy commented Aug 16, 2019

How would configurability work with federation?

@ara4n
Copy link
Member

ara4n commented Aug 16, 2019

i suspect we should just bump it to 256

@aaronraimist
Copy link
Contributor

aaronraimist commented Aug 16, 2019 via email

@Half-Shot
Copy link
Collaborator

Currently it's a local limit, not over federation.

@neilisfragile
Copy link
Contributor

We can bump to 256

The reason that 100 was chosen (over any other finite number) was to give enough space for what we thought would be most profiles, but short enough to make it harder to spread abusive content via profile names (which used to be a thing ...)

@richvdh
Copy link
Member

richvdh commented Aug 27, 2019

fixed by #5906

@richvdh richvdh closed this as completed Aug 27, 2019
@ulope
Copy link
Author

ulope commented Aug 28, 2019

Great! Thanks for the quick turnaround.

Do you have a notion when a new release that includes this change could happen?

@richvdh
Copy link
Member

richvdh commented Aug 28, 2019

releases normally happen every couple of weeks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
z-p2 (Deprecated Label)
Projects
None yet
Development

No branches or pull requests

8 participants